def revise(request, project_id):
project = project_api.get_project(project_api.id2uri(project_id))
badge = badge_api.get_badge(project['badge_uri'])
fetch_badge_resources(badge)
if request.method == 'POST':
form = RevisionForm(request.POST)
else:
form = RevisionForm()
if form.is_valid():
try:
project_api.revise_project(
project['uri'],
form.cleaned_data['improvement'],
form.cleaned_data.get('work_url', None)
)
except Exception as e:
messages.error(request, _(e.args[0]))
return http.HttpResponseRedirect(reverse('project_view', args=(project_id,)))
context = {
'badge': badge,
'project': project,
'form': form
}
return render_to_response(
'project/revise.html',
context,
context_instance=RequestContext(request)
)
def test_project_feedback_cycle(self):
# create badge
badge = badge_api.create_badge(**self.badge_values)
badge_api.publish_badge(badge['uri'])
user = p2pu_user_api.save_user('badgemaker', 'http://placeholdit.com/40x40', '*****@*****.**')
# create project
project_values = self.project_values.copy()
project_values['badge_uri'] = badge['uri']
project = project_api.create_project(**project_values)
# get feedback - has to be zero, there was not any feedback submitted yet
project_feedback = project_api.get_project_feedback(project['uri'])
self.assertEqual(len(project_feedback), 0)
# test that project can be revised - it can not, there has not been feedback given yet
self.assertFalse(project_api.can_revise_project(project['uri']))
# test that error is raised when revision is given - it has to be, there was no feedback given yet
with self.assertRaises(Exception):
project_api.revise_project(project['uri'], 'All better')
# test that project is ready for feedback
self.assertTrue(project_api.ready_for_feedback(project['uri']))
# submit feedback
project_api.submit_feedback(project['uri'], '/uri/user/badgemaker', 'Ugly', 'Bad', 'Good')
project_feedback = project_api.get_project_feedback(project['uri'])
self.assertEqual(len(project_feedback), 1)
self.assertIn('good', project_feedback[0])
self.assertIn('bad', project_feedback[0])
self.assertIn('ugly', project_feedback[0])
self.assertIn('expert_uri', project_feedback[0])
# test that multiple feedback cannont be submitted without a revision
#self.assertFalse(project_api.ready_for_feedback(project['uri']))
#with self.assertRaises(Exception):
# project_api.submit_feedback(project['uri'], '/uri/user/badgemaker', 'Ugly', 'Bad', 'Good')
project_api.revise_project(project['uri'], 'everything is better now!!')
project_feedback = project_api.get_project_feedback(project['uri'])
self.assertEqual(len(project_feedback), 2)
project_api.submit_feedback(project['uri'], '/uri/user/badgemaker', 'Ugly', 'Bad', 'Good')
project_api.revise_project(project['uri'], 'everything is better now, promise!!', work_url='http://mywork.com/new-and-improved')
project_feedback = project_api.get_project_feedback(project['uri'])
self.assertEqual(len(project_feedback), 4)
self.assertIn('improvement', project_feedback[1])
self.assertIn('date_created', project_feedback[1])
self.assertNotIn('work_url', project_feedback[1])
self.assertIn('improvement', project_feedback[3])
self.assertIn('work_url', project_feedback[3])
def test_award_partner_badge_as_partne(self):
#create a partner
partner = p2pu_user_api.create_partner('test partner')
# create a parnter badge
badge_values = self.badge_values.copy()
badge_values['partner_name'] = partner['name']
badge =badge_api.create_badge(**badge_values)
badge_api.publish_badge(badge['uri'])
# submit a project for a badge
project_values = self.project_values.copy()
project_values['badge_uri'] = badge['uri']
project = project_api.create_project(**project_values)
# give feedback as a partner
feedback = project_api.submit_feedback(
project['uri'],
self.badge_values['author_uri'],
'Good',
'Bad',
'Ugly',
)
self.assertEquals(feedback, project_api.submit_feedback_result.NOT_AWARDED)
# revise feedback
revision = project_api.revise_project(project['uri'], 'Some improvement')
self.assertEquals('Some improvement', revision['improvement'])
# give feedback and award a badge
feedback = project_api.submit_feedback(
project['uri'],
self.badge_values['author_uri'],
'SecondGood',
'SecondBad',
'SecondUgly',
award_badge=True
)
self.assertEquals(feedback, project_api.submit_feedback_result.AWARDED)
def test_badge_awarded_from_nonpartner_expert(self):
#create a partner
partner = p2pu_user_api.create_partner('Test parnter')
# create partner badge
new_badge_values = self.badge_values.copy()
new_badge_values['partner_name'] = partner['name']
# create a parnter badge
badge = badge_api.create_badge(**new_badge_values)
badge_api.publish_badge(badge['uri'])
# submit a project for a badge
project_values = self.project_values.copy()
project_values['badge_uri'] = badge['uri']
project = project_api.create_project(**project_values)
# award badge as a partner
feedback = project_api.submit_feedback(
project['uri'],
badge['author_uri'],
'Good',
'Bad',
'Ugly',
award_badge=True
)
self.assertEquals(feedback, project_api.submit_feedback_result.AWARDED)
# award badge
# HACK - needs well revision on how to refactor in order to test cycle properly
if project_api.submit_feedback_result.AWARDED:
with patch('badge.models.send_badge_awarded_notification') as mock_notification:
badge_api.award_badge(badge['uri'], project_values['author_uri'], badge['author_uri'], 'http://project.org/url')
self.assertIn(project_values['author_uri'], badge_api.get_badge_experts(badge['uri']))
# submit another project for a badge
another_project_values = {
'badge_uri': badge['uri'],
'author_uri': '/uri/user/anotheruser',
'title': 'Test Second Title',
'image_uri': '/uri/image/2',
'work_url': 'http://project.org/url',
'description': 'Did the test second time',
'reflection': 'Will not do it earlier and more next time',
'tags': ['test', 'tdd', 'bdd'],
}
project = project_api.create_project(**another_project_values)
# award badge as a non partner
feedback = project_api.submit_feedback(
project['uri'],
'/uri/user/testuser',
'Good',
'Bad',
'Ugly',
award_badge=True
)
self.assertEquals(feedback, project_api.submit_feedback_result.REQUIRES_APPROVAL)
# award badge as partner
feedback = project_api.submit_feedback(
project['uri'],
badge['author_uri'],
'Good',
'Bad',
'Ugly',
award_badge=True
)
self.assertEquals(feedback, project_api.submit_feedback_result.AWARDED)
# test that feedback can not be given anymore
with self.assertRaises(Exception):
project_api.submit_feedback(
project['uri'],
badge['author_uri'],
'Good',
'Bad',
'Ugly',
award_badge=True
)
# test that revision can not be given any longer either
with self.assertRaises(Exception):
project_api.revise_project(project['uri'], 'Some improvement')
