def assert_lines_lint(self, lines, should_pass, expected_output=None): self._error_collector.reset_errors() host = MockHost() checker = TestExpectationsChecker('test/TestExpectations', self._error_collector, host=host) # We should have failed to find a valid port object for that path. self.assertIsNone(checker._port_obj) # Now use a test port so we can check the lines. checker._port_obj = host.port_factory.get('test-mac-leopard') checker.check_test_expectations(expectations_str='\n'.join(lines), tests=[self._test_file]) checker.check_tabs(lines) if should_pass: self.assertEqual('', self._error_collector.get_errors()) elif expected_output: self.assertEqual(expected_output, self._error_collector.get_errors()) else: self.assertNotEquals('', self._error_collector.get_errors()) # Note that a patch might change a line that introduces errors elsewhere, but we # don't want to lint the whole file (it can unfairly punish patches for pre-existing errors). # We rely on a separate lint-webkitpy step on the bots to keep the whole file okay. # FIXME: See https://bugs.webkit.org/show_bug.cgi?id=104712 . self.assertFalse(self._error_collector.turned_off_filtering)
def assert_lines_lint(self, lines, should_pass, expected_output=None): self._error_collector.reset_errors() host = MockHost() checker = TestExpectationsChecker('test/TestExpectations', self._error_collector, host=host) # We should have a valid port, but override it with a test port so we # can check the lines. self.assertIsNotNone(checker._port_obj) checker._port_obj = host.port_factory.get('test-mac-mac10.10') checker.check_test_expectations(expectations_str='\n'.join(lines), tests=[self._test_file]) checker.check_tabs(lines) if should_pass: self.assertEqual('', self._error_collector.get_errors()) elif expected_output: self.assertEqual(expected_output, self._error_collector.get_errors()) else: self.assertNotEquals('', self._error_collector.get_errors()) # Note that a patch might change a line that introduces errors elsewhere, but we # don't want to lint the whole file (it can unfairly punish patches for pre-existing errors). # We rely on a separate lint-webkitpy step on the bots to keep the whole file okay. # FIXME: See https://bugs.webkit.org/show_bug.cgi?id=104712 . self.assertFalse(self._error_collector.turned_off_filtering)
def assert_lines_lint(self, lines, should_pass, expected_output=None): self._error_collector.reset_errors() host = MockHost() checker = TestExpectationsChecker('test/test_expectations.txt', self._error_collector, host=host) # We should have failed to find a valid port object for that path. self.assertEquals(checker._port_obj, None) # Now use a test port so we can check the lines. checker._port_obj = host.port_factory.get('test-mac-leopard') checker.check_test_expectations(expectations_str='\n'.join(lines), tests=[self._test_file], overrides=None) checker.check_tabs(lines) if should_pass: self.assertEqual('', self._error_collector.get_errors()) elif expected_output: self.assertEquals(expected_output, self._error_collector.get_errors()) else: self.assertNotEquals('', self._error_collector.get_errors()) self.assertTrue(self._error_collector.turned_off_filtering)
def assert_lines_lint(self, lines, expected): self._error_collector.reset_errors() checker = TestExpectationsChecker('test/test_expectations.txt', self._error_collector) checker.check_test_expectations(expectations_str='\n'.join(lines), tests=[self._test_file], overrides=None) checker.check_tabs(lines) self.assertEqual(expected, self._error_collector.get_errors())
def assert_lines_lint(self, lines, should_pass, expected_output=None): self._error_collector.reset_errors() checker = TestExpectationsChecker('test/test_expectations.txt', self._error_collector, host=MockHost()) checker.check_test_expectations(expectations_str='\n'.join(lines), tests=[self._test_file], overrides=None) checker.check_tabs(lines) if should_pass: self.assertEqual('', self._error_collector.get_errors()) elif expected_output: self.assertEquals(expected_output, self._error_collector.get_errors()) else: self.assertNotEquals('', self._error_collector.get_errors()) self.assertTrue(self._error_collector.turned_off_filtering)
def assert_lines_lint(self, lines, should_pass, expected_output=None): self._error_collector.reset_errors() host = MockHost() checker = TestExpectationsChecker('test/TestExpectations', self._error_collector, host=host) # We should have failed to find a valid port object for that path. self.assertEquals(checker._port_obj, None) # Now use a test port so we can check the lines. checker._port_obj = host.port_factory.get('test-mac-leopard') checker.check_test_expectations(expectations_str='\n'.join(lines), tests=[self._test_file]) checker.check_tabs(lines) if should_pass: self.assertEqual('', self._error_collector.get_errors()) elif expected_output: self.assertEquals(expected_output, self._error_collector.get_errors()) else: self.assertNotEquals('', self._error_collector.get_errors()) self.assertTrue(self._error_collector.turned_off_filtering)