def test_not_enough_assignments_to_allocate(self):
"""Test for the case when there are too few assignments in the pool."""
email = '*****@*****.**'
name = 'Student 1'
submission = transforms.dumps([
{'index': 0, 'type': 'regex', 'value': 'S1-1', 'correct': True},
{'index': 1, 'type': 'choices', 'value': 3, 'correct': False},
{'index': 2, 'type': 'regex', 'value': 'is-S1', 'correct': True},
])
payload = {
'answers': submission, 'assessment_type': LEGACY_REVIEW_UNIT_ID}
actions.login(email)
actions.register(self, name)
response = actions.submit_assessment(
self, LEGACY_REVIEW_UNIT_ID, payload)
# The student goes to the review dashboard and requests an assignment
# to review -- but there is nothing to review.
response = actions.request_new_review(
self, LEGACY_REVIEW_UNIT_ID, expected_status_code=200)
actions.assert_does_not_contain('Assignment to review', response.body)
actions.assert_contains(
'Sorry, there are no new submissions ', response.body)
actions.assert_contains('disabled="true"', response.body)
actions.logout()
def test_add_reviewer(self):
"""Test that admin can add a reviewer, and cannot re-add reviewers."""
email = '*****@*****.**'
name = 'Test Add Reviewer'
submission = transforms.dumps([
{'index': 0, 'type': 'regex', 'value': 'First answer to Q1',
'correct': True},
{'index': 1, 'type': 'choices', 'value': 3, 'correct': False},
{'index': 2, 'type': 'regex', 'value': 'First answer to Q3',
'correct': True},
])
payload = {
'answers': submission, 'assessment_type': LEGACY_REVIEW_UNIT_ID}
actions.login(email)
actions.register(self, name)
response = actions.submit_assessment(
self, LEGACY_REVIEW_UNIT_ID, payload)
# There is nothing to review on the review dashboard.
response = actions.request_new_review(
self, LEGACY_REVIEW_UNIT_ID, expected_status_code=200)
actions.assert_does_not_contain('Assignment to review', response.body)
actions.assert_contains(
'Sorry, there are no new submissions ', response.body)
actions.logout()
# The admin assigns the student to review his own work.
actions.login(email, is_admin=True)
response = actions.add_reviewer(
self, LEGACY_REVIEW_UNIT_ID, email, email)
actions.assert_equals(response.status_int, 302)
response = self.get(response.location)
actions.assert_does_not_contain(
'Error 412: The reviewer is already assigned', response.body)
actions.assert_contains('First answer to Q1', response.body)
actions.assert_contains(
'Review 1 from [email protected]', response.body)
# The admin repeats the 'add reviewer' action. This should fail.
response = actions.add_reviewer(
self, LEGACY_REVIEW_UNIT_ID, email, email)
actions.assert_equals(response.status_int, 302)
response = self.get(response.location)
actions.assert_contains(
'Error 412: The reviewer is already assigned', response.body)
def test_not_enough_assignments_to_allocate(self):
"""Test for the case when there are too few assignments in the pool."""
email = '*****@*****.**'
name = 'Student 1'
submission = transforms.dumps([
{
'index': 0,
'type': 'regex',
'value': 'S1-1',
'correct': True
},
{
'index': 1,
'type': 'choices',
'value': 3,
'correct': False
},
{
'index': 2,
'type': 'regex',
'value': 'is-S1',
'correct': True
},
])
payload = {
'answers': submission,
'assessment_type': LEGACY_REVIEW_UNIT_ID
}
actions.login(email)
actions.register(self, name)
response = actions.submit_assessment(self, LEGACY_REVIEW_UNIT_ID,
payload)
# The student goes to the review dashboard and requests an assignment
# to review -- but there is nothing to review.
response = actions.request_new_review(self,
LEGACY_REVIEW_UNIT_ID,
expected_status_code=200)
actions.assert_does_not_contain('Assignment to review', response.body)
actions.assert_contains('Sorry, there are no new submissions ',
response.body)
actions.assert_contains('disabled="true"', response.body)
actions.logout()
def test_peer_review_analytics(self):
"""Test analytics page on course dashboard."""
student1 = '*****@*****.**'
name1 = 'Test Student 1'
student2 = '*****@*****.**'
name2 = 'Test Student 2'
peer = {'assessment_type': 'ReviewAssessmentExample'}
# Student 1 submits a peer review assessment.
actions.login(student1)
actions.register(self, name1)
actions.submit_assessment(self, 'ReviewAssessmentExample', peer)
actions.logout()
# Student 2 submits the same peer review assessment.
actions.login(student2)
actions.register(self, name2)
actions.submit_assessment(self, 'ReviewAssessmentExample', peer)
actions.logout()
email = '*****@*****.**'
# The admin looks at the analytics page on the dashboard.
actions.login(email, is_admin=True)
response = self.get('dashboard?action=peer_review')
actions.assert_contains(
'Google > Dashboard > Manage > Peer review',
response.body)
actions.assert_contains('have not been calculated yet', response.body)
response = response.forms['gcb-generate-analytics-data'].submit(
).follow()
assert len(self.taskq.GetTasks('default')) == 1
actions.assert_contains('is running', response.body)
self.execute_all_deferred_tasks()
response = self.get(response.request.url)
actions.assert_contains('were last updated at', response.body)
actions.assert_contains('Peer review', response.body)
actions.assert_contains('Sample peer review assignment', response.body)
# JSON code for the completion statistics.
actions.assert_contains('"[{\\"stats\\": [2]', response.body)
actions.logout()
# Student2 requests a review.
actions.login(student2)
response = actions.request_new_review(
self, controllers_tests.LEGACY_REVIEW_UNIT_ID)
review_step_key_2_for_1 = controllers_tests.get_review_step_key(
response)
actions.assert_contains('Assignment to review', response.body)
# Student2 submits the review.
response = actions.submit_review(
self, controllers_tests.LEGACY_REVIEW_UNIT_ID,
review_step_key_2_for_1,
controllers_tests.get_review_payload('R2for1'))
actions.assert_contains('Your review has been submitted successfully',
response.body)
actions.logout()
actions.login(email, is_admin=True)
response = self.get('dashboard?action=peer_review')
actions.assert_contains(
'Google > Dashboard > Manage > Peer review',
response.body)
response = response.forms['gcb-generate-analytics-data'].submit(
).follow()
self.execute_all_deferred_tasks()
response = self.get(response.request.url)
actions.assert_contains('Peer review', response.body)
# JSON code for the completion statistics.
actions.assert_contains('"[{\\"stats\\": [1, 1]', response.body)
actions.logout()
def test_add_reviewer(self):
"""Test that admin can add a reviewer, and cannot re-add reviewers."""
email = '*****@*****.**'
name = 'Test Add Reviewer'
submission = transforms.dumps([
{
'index': 0,
'type': 'regex',
'value': 'First answer to Q1',
'correct': True
},
{
'index': 1,
'type': 'choices',
'value': 3,
'correct': False
},
{
'index': 2,
'type': 'regex',
'value': 'First answer to Q3',
'correct': True
},
])
payload = {
'answers': submission,
'assessment_type': LEGACY_REVIEW_UNIT_ID
}
actions.login(email)
actions.register(self, name)
response = actions.submit_assessment(self, LEGACY_REVIEW_UNIT_ID,
payload)
# There is nothing to review on the review dashboard.
response = actions.request_new_review(self,
LEGACY_REVIEW_UNIT_ID,
expected_status_code=200)
actions.assert_does_not_contain('Assignment to review', response.body)
actions.assert_contains('Sorry, there are no new submissions ',
response.body)
actions.logout()
# The admin assigns the student to review his own work.
actions.login(email, is_admin=True)
response = actions.add_reviewer(self, LEGACY_REVIEW_UNIT_ID, email,
email)
actions.assert_equals(response.status_int, 302)
response = self.get(response.location)
actions.assert_does_not_contain(
'Error 412: The reviewer is already assigned', response.body)
actions.assert_contains('First answer to Q1', response.body)
actions.assert_contains('Review 1 from [email protected]',
response.body)
# The admin repeats the 'add reviewer' action. This should fail.
response = actions.add_reviewer(self, LEGACY_REVIEW_UNIT_ID, email,
email)
actions.assert_equals(response.status_int, 302)
response = self.get(response.location)
actions.assert_contains('Error 412: The reviewer is already assigned',
response.body)
def test_independence_of_draft_reviews(self):
"""Test that draft reviews do not interfere with each other."""
email1 = '*****@*****.**'
name1 = 'Student 1'
submission1 = transforms.dumps([
{
'index': 0,
'type': 'regex',
'value': 'S1-1',
'correct': True
},
{
'index': 1,
'type': 'choices',
'value': 3,
'correct': False
},
{
'index': 2,
'type': 'regex',
'value': 'is-S1',
'correct': True
},
])
payload1 = {
'answers': submission1,
'assessment_type': LEGACY_REVIEW_UNIT_ID
}
email2 = '*****@*****.**'
name2 = 'Student 2'
submission2 = transforms.dumps([
{
'index': 0,
'type': 'regex',
'value': 'S2-1',
'correct': True
},
{
'index': 1,
'type': 'choices',
'value': 3,
'correct': False
},
{
'index': 2,
'type': 'regex',
'value': 'not-S1',
'correct': True
},
])
payload2 = {
'answers': submission2,
'assessment_type': LEGACY_REVIEW_UNIT_ID
}
email3 = '*****@*****.**'
name3 = 'Student 3'
submission3 = transforms.dumps([
{
'index': 0,
'type': 'regex',
'value': 'S3-1',
'correct': True
},
{
'index': 1,
'type': 'choices',
'value': 3,
'correct': False
},
{
'index': 2,
'type': 'regex',
'value': 'not-S1',
'correct': True
},
])
payload3 = {
'answers': submission3,
'assessment_type': LEGACY_REVIEW_UNIT_ID
}
# Student 1 submits the assignment.
actions.login(email1)
actions.register(self, name1)
response = actions.submit_assessment(self, LEGACY_REVIEW_UNIT_ID,
payload1)
actions.logout()
# Student 2 logs in and submits the assignment.
actions.login(email2)
actions.register(self, name2)
response = actions.submit_assessment(self, LEGACY_REVIEW_UNIT_ID,
payload2)
actions.logout()
# Student 3 logs in and submits the assignment.
actions.login(email3)
actions.register(self, name3)
response = actions.submit_assessment(self, LEGACY_REVIEW_UNIT_ID,
payload3)
actions.logout()
# Student 1 logs in and requests two assignments to review.
actions.login(email1)
response = self.get('/reviewdashboard?unit=%s' % LEGACY_REVIEW_UNIT_ID)
response = actions.request_new_review(self, LEGACY_REVIEW_UNIT_ID)
actions.assert_equals(response.status_int, 200)
actions.assert_contains('Assignment to review', response.body)
actions.assert_contains('not-S1', response.body)
review_step_key_1_for_someone = get_review_step_key(response)
response = actions.request_new_review(self, LEGACY_REVIEW_UNIT_ID)
actions.assert_equals(response.status_int, 200)
actions.assert_contains('Assignment to review', response.body)
actions.assert_contains('not-S1', response.body)
review_step_key_1_for_someone_else = get_review_step_key(response)
self.assertNotEqual(review_step_key_1_for_someone,
review_step_key_1_for_someone_else)
# Student 1 submits two draft reviews.
response = actions.submit_review(
self, LEGACY_REVIEW_UNIT_ID, review_step_key_1_for_someone,
get_review_payload('R1forFirst', is_draft=True))
actions.assert_contains('Your review has been saved.', response.body)
response = actions.submit_review(
self, LEGACY_REVIEW_UNIT_ID, review_step_key_1_for_someone_else,
get_review_payload('R1forSecond', is_draft=True))
actions.assert_contains('Your review has been saved.', response.body)
# The two draft reviews should still be different when subsequently
# accessed.
response = self.get(
'review?unit=%s&key=%s' %
(LEGACY_REVIEW_UNIT_ID, review_step_key_1_for_someone))
actions.assert_contains('R1forFirst', response.body)
response = self.get(
'review?unit=%s&key=%s' %
(LEGACY_REVIEW_UNIT_ID, review_step_key_1_for_someone_else))
actions.assert_contains('R1forSecond', response.body)
# Student 1 logs out.
actions.logout()
def test_draft_review_behaviour(self):
"""Test correctness of draft review visibility."""
email1 = '*****@*****.**'
name1 = 'Student 1'
submission1 = transforms.dumps([
{
'index': 0,
'type': 'regex',
'value': 'S1-1',
'correct': True
},
{
'index': 1,
'type': 'choices',
'value': 3,
'correct': False
},
{
'index': 2,
'type': 'regex',
'value': 'is-S1',
'correct': True
},
])
payload1 = {
'answers': submission1,
'assessment_type': LEGACY_REVIEW_UNIT_ID
}
email2 = '*****@*****.**'
name2 = 'Student 2'
submission2 = transforms.dumps([
{
'index': 0,
'type': 'regex',
'value': 'S2-1',
'correct': True
},
{
'index': 1,
'type': 'choices',
'value': 3,
'correct': False
},
{
'index': 2,
'type': 'regex',
'value': 'not-S1',
'correct': True
},
])
payload2 = {
'answers': submission2,
'assessment_type': LEGACY_REVIEW_UNIT_ID
}
email3 = '*****@*****.**'
name3 = 'Student 3'
submission3 = transforms.dumps([
{
'index': 0,
'type': 'regex',
'value': 'S3-1',
'correct': True
},
{
'index': 1,
'type': 'choices',
'value': 3,
'correct': False
},
{
'index': 2,
'type': 'regex',
'value': 'not-S1',
'correct': True
},
])
payload3 = {
'answers': submission3,
'assessment_type': LEGACY_REVIEW_UNIT_ID
}
# Student 1 submits the assignment.
actions.login(email1)
actions.register(self, name1)
response = actions.submit_assessment(self, LEGACY_REVIEW_UNIT_ID,
payload1)
actions.logout()
# Student 2 logs in and submits the assignment.
actions.login(email2)
actions.register(self, name2)
response = actions.submit_assessment(self, LEGACY_REVIEW_UNIT_ID,
payload2)
# Student 2 requests a review, and is given Student 1's assignment.
response = actions.request_new_review(self, LEGACY_REVIEW_UNIT_ID)
review_step_key_2_for_1 = get_review_step_key(response)
actions.assert_contains('S1-1', response.body)
# Student 2 saves her review as a draft.
review_2_for_1_payload = get_review_payload('R2for1', is_draft=True)
response = actions.submit_review(self, LEGACY_REVIEW_UNIT_ID,
review_step_key_2_for_1,
review_2_for_1_payload)
actions.assert_contains('Your review has been saved.', response.body)
response = self.get('reviewdashboard?unit=%s' % LEGACY_REVIEW_UNIT_ID)
actions.assert_equals(response.status_int, 200)
actions.assert_contains('(Draft)', response.body)
# Student 2's draft is still changeable.
response = actions.view_review(self, LEGACY_REVIEW_UNIT_ID,
review_step_key_2_for_1)
actions.assert_contains('Submit Review', response.body)
response = actions.submit_review(self, LEGACY_REVIEW_UNIT_ID,
review_step_key_2_for_1,
review_2_for_1_payload)
actions.assert_contains('Your review has been saved.', response.body)
# Student 2 logs out.
actions.logout()
# Student 3 submits the assignment.
actions.login(email3)
actions.register(self, name3)
response = actions.submit_assessment(self, LEGACY_REVIEW_UNIT_ID,
payload3)
actions.logout()
# Student 1 logs in and requests two assignments to review.
actions.login(email1)
response = self.get('/reviewdashboard?unit=%s' % LEGACY_REVIEW_UNIT_ID)
response = actions.request_new_review(self, LEGACY_REVIEW_UNIT_ID)
actions.assert_contains('Assignment to review', response.body)
actions.assert_contains('not-S1', response.body)
review_step_key_1_for_someone = get_review_step_key(response)
response = actions.request_new_review(self, LEGACY_REVIEW_UNIT_ID)
actions.assert_contains('Assignment to review', response.body)
actions.assert_contains('not-S1', response.body)
review_step_key_1_for_someone_else = get_review_step_key(response)
response = self.get('reviewdashboard?unit=%s' % LEGACY_REVIEW_UNIT_ID)
actions.assert_equals(response.status_int, 200)
actions.assert_contains('disabled="true"', response.body)
# Student 1 submits both reviews, fulfilling his quota.
review_1_for_other_payload = get_review_payload('R1for')
response = actions.submit_review(self, LEGACY_REVIEW_UNIT_ID,
review_step_key_1_for_someone,
review_1_for_other_payload)
actions.assert_contains('Your review has been submitted successfully',
response.body)
response = actions.submit_review(self, LEGACY_REVIEW_UNIT_ID,
review_step_key_1_for_someone_else,
review_1_for_other_payload)
actions.assert_contains('Your review has been submitted successfully',
response.body)
response = self.get('/reviewdashboard?unit=%s' % LEGACY_REVIEW_UNIT_ID)
actions.assert_contains('(Completed)', response.body)
actions.assert_does_not_contain('(Draft)', response.body)
# Although Student 1 has submitted 2 reviews, he cannot view Student
# 2's review because it is still in Draft status.
response = self.get('assessment?name=%s' % LEGACY_REVIEW_UNIT_ID)
actions.assert_equals(response.status_int, 200)
actions.assert_contains('You have not received any peer reviews yet.',
response.body)
actions.assert_does_not_contain('R2for1', response.body)
# Student 1 logs out.
actions.logout()
# Student 2 submits her review for Student 1's assignment.
actions.login(email2)
response = self.get('review?unit=%s&key=%s' %
(LEGACY_REVIEW_UNIT_ID, review_step_key_2_for_1))
actions.assert_does_not_contain('Submitted review', response.body)
response = actions.submit_review(self, LEGACY_REVIEW_UNIT_ID,
review_step_key_2_for_1,
get_review_payload('R2for1'))
actions.assert_contains('Your review has been submitted successfully',
response.body)
# Her review is now read-only.
response = self.get('review?unit=%s&key=%s' %
(LEGACY_REVIEW_UNIT_ID, review_step_key_2_for_1))
actions.assert_contains('Submitted review', response.body)
actions.assert_contains('R2for1', response.body)
# Student 2 logs out.
actions.logout()
# Now Student 1 can see the review he has received from Student 2.
actions.login(email1)
response = self.get('assessment?name=%s' % LEGACY_REVIEW_UNIT_ID)
actions.assert_equals(response.status_int, 200)
actions.assert_contains('R2for1', response.body)
def test_reviewer_cannot_impersonate_another_reviewer(self):
"""Test that one reviewer cannot use another's review step key."""
email1 = '*****@*****.**'
name1 = 'Student 1'
submission1 = transforms.dumps([
{
'index': 0,
'type': 'regex',
'value': 'S1-1',
'correct': True
},
{
'index': 1,
'type': 'choices',
'value': 3,
'correct': False
},
{
'index': 2,
'type': 'regex',
'value': 'is-S1',
'correct': True
},
])
payload1 = {
'answers': submission1,
'assessment_type': LEGACY_REVIEW_UNIT_ID
}
email2 = '*****@*****.**'
name2 = 'Student 2'
submission2 = transforms.dumps([
{
'index': 0,
'type': 'regex',
'value': 'S2-1',
'correct': True
},
{
'index': 1,
'type': 'choices',
'value': 3,
'correct': False
},
{
'index': 2,
'type': 'regex',
'value': 'not-S1',
'correct': True
},
])
payload2 = {
'answers': submission2,
'assessment_type': LEGACY_REVIEW_UNIT_ID
}
email3 = '*****@*****.**'
name3 = 'Student 3'
submission3 = transforms.dumps([
{
'index': 0,
'type': 'regex',
'value': 'S3-1',
'correct': True
},
{
'index': 1,
'type': 'choices',
'value': 3,
'correct': False
},
{
'index': 2,
'type': 'regex',
'value': 'not-S1',
'correct': True
},
])
payload3 = {
'answers': submission3,
'assessment_type': LEGACY_REVIEW_UNIT_ID
}
# Student 1 submits the assignment.
actions.login(email1)
actions.register(self, name1)
response = actions.submit_assessment(self, LEGACY_REVIEW_UNIT_ID,
payload1)
actions.logout()
# Student 2 logs in and submits the assignment.
actions.login(email2)
actions.register(self, name2)
response = actions.submit_assessment(self, LEGACY_REVIEW_UNIT_ID,
payload2)
# Student 2 requests a review, and is given Student 1's assignment.
response = actions.request_new_review(self, LEGACY_REVIEW_UNIT_ID)
review_step_key_2_for_1 = get_review_step_key(response)
actions.assert_contains('S1-1', response.body)
actions.logout()
# Student 3 logs in, and submits the assignment.
actions.login(email3)
actions.register(self, name3)
response = actions.submit_assessment(self, LEGACY_REVIEW_UNIT_ID,
payload3)
# Student 3 tries to view Student 1's assignment using Student 2's
# review step key, but is not allowed to.
response = actions.view_review(self,
LEGACY_REVIEW_UNIT_ID,
review_step_key_2_for_1,
expected_status_code=404)
# Student 3 logs out.
actions.logout()
def test_peer_review_analytics(self):
"""Test analytics page on course dashboard."""
student1 = '*****@*****.**'
name1 = 'Test Student 1'
student2 = '*****@*****.**'
name2 = 'Test Student 2'
peer = {'assessment_type': 'ReviewAssessmentExample'}
# Student 1 submits a peer review assessment.
actions.login(student1)
actions.register(self, name1)
actions.submit_assessment(self, 'ReviewAssessmentExample', peer)
actions.logout()
# Student 2 submits the same peer review assessment.
actions.login(student2)
actions.register(self, name2)
actions.submit_assessment(self, 'ReviewAssessmentExample', peer)
actions.logout()
email = '*****@*****.**'
# The admin looks at the analytics page on the dashboard.
actions.login(email, is_admin=True)
response = self.get('dashboard?action=peer_review')
actions.assert_contains(
'Google > Dashboard > Manage > Peer review',
response.body)
actions.assert_contains('have not been calculated yet', response.body)
response = response.forms[
'gcb-generate-analytics-data'].submit().follow()
assert len(self.taskq.GetTasks('default')) == 1
actions.assert_contains('is running', response.body)
self.execute_all_deferred_tasks()
response = self.get(response.request.url)
actions.assert_contains('were last updated at', response.body)
actions.assert_contains('Peer review', response.body)
actions.assert_contains('Sample peer review assignment', response.body)
# JSON code for the completion statistics.
actions.assert_contains('"[{\\"stats\\": [2]', response.body)
actions.logout()
# Student2 requests a review.
actions.login(student2)
response = actions.request_new_review(
self, controllers_tests.LEGACY_REVIEW_UNIT_ID)
review_step_key_2_for_1 = controllers_tests.get_review_step_key(
response)
actions.assert_contains('Assignment to review', response.body)
# Student2 submits the review.
response = actions.submit_review(
self, controllers_tests.LEGACY_REVIEW_UNIT_ID,
review_step_key_2_for_1,
controllers_tests.get_review_payload('R2for1'))
actions.assert_contains(
'Your review has been submitted successfully', response.body)
actions.logout()
actions.login(email, is_admin=True)
response = self.get('dashboard?action=peer_review')
actions.assert_contains(
'Google > Dashboard > Manage > Peer review',
response.body)
response = response.forms[
'gcb-generate-analytics-data'].submit().follow()
self.execute_all_deferred_tasks()
response = self.get(response.request.url)
actions.assert_contains('Peer review', response.body)
# JSON code for the completion statistics.
actions.assert_contains('"[{\\"stats\\": [1, 1]', response.body)
actions.logout()
def test_independence_of_draft_reviews(self):
"""Test that draft reviews do not interfere with each other."""
email1 = '*****@*****.**'
name1 = 'Student 1'
submission1 = transforms.dumps([
{'index': 0, 'type': 'regex', 'value': 'S1-1', 'correct': True},
{'index': 1, 'type': 'choices', 'value': 3, 'correct': False},
{'index': 2, 'type': 'regex', 'value': 'is-S1', 'correct': True},
])
payload1 = {
'answers': submission1, 'assessment_type': LEGACY_REVIEW_UNIT_ID}
email2 = '*****@*****.**'
name2 = 'Student 2'
submission2 = transforms.dumps([
{'index': 0, 'type': 'regex', 'value': 'S2-1', 'correct': True},
{'index': 1, 'type': 'choices', 'value': 3, 'correct': False},
{'index': 2, 'type': 'regex', 'value': 'not-S1', 'correct': True},
])
payload2 = {
'answers': submission2, 'assessment_type': LEGACY_REVIEW_UNIT_ID}
email3 = '*****@*****.**'
name3 = 'Student 3'
submission3 = transforms.dumps([
{'index': 0, 'type': 'regex', 'value': 'S3-1', 'correct': True},
{'index': 1, 'type': 'choices', 'value': 3, 'correct': False},
{'index': 2, 'type': 'regex', 'value': 'not-S1', 'correct': True},
])
payload3 = {
'answers': submission3, 'assessment_type': LEGACY_REVIEW_UNIT_ID}
# Student 1 submits the assignment.
actions.login(email1)
actions.register(self, name1)
response = actions.submit_assessment(
self, LEGACY_REVIEW_UNIT_ID, payload1)
actions.logout()
# Student 2 logs in and submits the assignment.
actions.login(email2)
actions.register(self, name2)
response = actions.submit_assessment(
self, LEGACY_REVIEW_UNIT_ID, payload2)
actions.logout()
# Student 3 logs in and submits the assignment.
actions.login(email3)
actions.register(self, name3)
response = actions.submit_assessment(
self, LEGACY_REVIEW_UNIT_ID, payload3)
actions.logout()
# Student 1 logs in and requests two assignments to review.
actions.login(email1)
response = self.get('/reviewdashboard?unit=%s' % LEGACY_REVIEW_UNIT_ID)
response = actions.request_new_review(self, LEGACY_REVIEW_UNIT_ID)
actions.assert_equals(response.status_int, 200)
actions.assert_contains('Assignment to review', response.body)
actions.assert_contains('not-S1', response.body)
review_step_key_1_for_someone = get_review_step_key(response)
response = actions.request_new_review(self, LEGACY_REVIEW_UNIT_ID)
actions.assert_equals(response.status_int, 200)
actions.assert_contains('Assignment to review', response.body)
actions.assert_contains('not-S1', response.body)
review_step_key_1_for_someone_else = get_review_step_key(response)
self.assertNotEqual(
review_step_key_1_for_someone, review_step_key_1_for_someone_else)
# Student 1 submits two draft reviews.
response = actions.submit_review(
self, LEGACY_REVIEW_UNIT_ID, review_step_key_1_for_someone,
get_review_payload('R1forFirst', is_draft=True))
actions.assert_contains('Your review has been saved.', response.body)
response = actions.submit_review(
self, LEGACY_REVIEW_UNIT_ID, review_step_key_1_for_someone_else,
get_review_payload('R1forSecond', is_draft=True))
actions.assert_contains('Your review has been saved.', response.body)
# The two draft reviews should still be different when subsequently
# accessed.
response = self.get('review?unit=%s&key=%s' % (
LEGACY_REVIEW_UNIT_ID, review_step_key_1_for_someone))
actions.assert_contains('R1forFirst', response.body)
response = self.get('review?unit=%s&key=%s' % (
LEGACY_REVIEW_UNIT_ID, review_step_key_1_for_someone_else))
actions.assert_contains('R1forSecond', response.body)
# Student 1 logs out.
actions.logout()
def test_draft_review_behaviour(self):
"""Test correctness of draft review visibility."""
email1 = '*****@*****.**'
name1 = 'Student 1'
submission1 = transforms.dumps([
{'index': 0, 'type': 'regex', 'value': 'S1-1', 'correct': True},
{'index': 1, 'type': 'choices', 'value': 3, 'correct': False},
{'index': 2, 'type': 'regex', 'value': 'is-S1', 'correct': True},
])
payload1 = {
'answers': submission1, 'assessment_type': LEGACY_REVIEW_UNIT_ID}
email2 = '*****@*****.**'
name2 = 'Student 2'
submission2 = transforms.dumps([
{'index': 0, 'type': 'regex', 'value': 'S2-1', 'correct': True},
{'index': 1, 'type': 'choices', 'value': 3, 'correct': False},
{'index': 2, 'type': 'regex', 'value': 'not-S1', 'correct': True},
])
payload2 = {
'answers': submission2, 'assessment_type': LEGACY_REVIEW_UNIT_ID}
email3 = '*****@*****.**'
name3 = 'Student 3'
submission3 = transforms.dumps([
{'index': 0, 'type': 'regex', 'value': 'S3-1', 'correct': True},
{'index': 1, 'type': 'choices', 'value': 3, 'correct': False},
{'index': 2, 'type': 'regex', 'value': 'not-S1', 'correct': True},
])
payload3 = {
'answers': submission3, 'assessment_type': LEGACY_REVIEW_UNIT_ID}
# Student 1 submits the assignment.
actions.login(email1)
actions.register(self, name1)
response = actions.submit_assessment(
self, LEGACY_REVIEW_UNIT_ID, payload1)
actions.logout()
# Student 2 logs in and submits the assignment.
actions.login(email2)
actions.register(self, name2)
response = actions.submit_assessment(
self, LEGACY_REVIEW_UNIT_ID, payload2)
# Student 2 requests a review, and is given Student 1's assignment.
response = actions.request_new_review(self, LEGACY_REVIEW_UNIT_ID)
review_step_key_2_for_1 = get_review_step_key(response)
actions.assert_contains('S1-1', response.body)
# Student 2 saves her review as a draft.
review_2_for_1_payload = get_review_payload(
'R2for1', is_draft=True)
response = actions.submit_review(
self, LEGACY_REVIEW_UNIT_ID, review_step_key_2_for_1,
review_2_for_1_payload)
actions.assert_contains('Your review has been saved.', response.body)
response = self.get('reviewdashboard?unit=%s' % LEGACY_REVIEW_UNIT_ID)
actions.assert_equals(response.status_int, 200)
actions.assert_contains('(Draft)', response.body)
# Student 2's draft is still changeable.
response = actions.view_review(
self, LEGACY_REVIEW_UNIT_ID, review_step_key_2_for_1)
actions.assert_contains('Submit Review', response.body)
response = actions.submit_review(
self, LEGACY_REVIEW_UNIT_ID, review_step_key_2_for_1,
review_2_for_1_payload)
actions.assert_contains('Your review has been saved.', response.body)
# Student 2 logs out.
actions.logout()
# Student 3 submits the assignment.
actions.login(email3)
actions.register(self, name3)
response = actions.submit_assessment(
self, LEGACY_REVIEW_UNIT_ID, payload3)
actions.logout()
# Student 1 logs in and requests two assignments to review.
actions.login(email1)
response = self.get('/reviewdashboard?unit=%s' % LEGACY_REVIEW_UNIT_ID)
response = actions.request_new_review(self, LEGACY_REVIEW_UNIT_ID)
actions.assert_contains('Assignment to review', response.body)
actions.assert_contains('not-S1', response.body)
review_step_key_1_for_someone = get_review_step_key(response)
response = actions.request_new_review(self, LEGACY_REVIEW_UNIT_ID)
actions.assert_contains('Assignment to review', response.body)
actions.assert_contains('not-S1', response.body)
review_step_key_1_for_someone_else = get_review_step_key(response)
response = self.get('reviewdashboard?unit=%s' % LEGACY_REVIEW_UNIT_ID)
actions.assert_equals(response.status_int, 200)
actions.assert_contains('disabled="true"', response.body)
# Student 1 submits both reviews, fulfilling his quota.
review_1_for_other_payload = get_review_payload('R1for')
response = actions.submit_review(
self, LEGACY_REVIEW_UNIT_ID, review_step_key_1_for_someone,
review_1_for_other_payload)
actions.assert_contains(
'Your review has been submitted successfully', response.body)
response = actions.submit_review(
self, LEGACY_REVIEW_UNIT_ID, review_step_key_1_for_someone_else,
review_1_for_other_payload)
actions.assert_contains(
'Your review has been submitted successfully', response.body)
response = self.get('/reviewdashboard?unit=%s' % LEGACY_REVIEW_UNIT_ID)
actions.assert_contains('(Completed)', response.body)
actions.assert_does_not_contain('(Draft)', response.body)
# Although Student 1 has submitted 2 reviews, he cannot view Student
# 2's review because it is still in Draft status.
response = self.get('assessment?name=%s' % LEGACY_REVIEW_UNIT_ID)
actions.assert_equals(response.status_int, 200)
actions.assert_contains(
'You have not received any peer reviews yet.', response.body)
actions.assert_does_not_contain('R2for1', response.body)
# Student 1 logs out.
actions.logout()
# Student 2 submits her review for Student 1's assignment.
actions.login(email2)
response = self.get('review?unit=%s&key=%s' % (
LEGACY_REVIEW_UNIT_ID, review_step_key_2_for_1))
actions.assert_does_not_contain('Submitted review', response.body)
response = actions.submit_review(
self, LEGACY_REVIEW_UNIT_ID, review_step_key_2_for_1,
get_review_payload('R2for1'))
actions.assert_contains(
'Your review has been submitted successfully', response.body)
# Her review is now read-only.
response = self.get('review?unit=%s&key=%s' % (
LEGACY_REVIEW_UNIT_ID, review_step_key_2_for_1))
actions.assert_contains('Submitted review', response.body)
actions.assert_contains('R2for1', response.body)
# Student 2 logs out.
actions.logout()
# Now Student 1 can see the review he has received from Student 2.
actions.login(email1)
response = self.get('assessment?name=%s' % LEGACY_REVIEW_UNIT_ID)
actions.assert_equals(response.status_int, 200)
actions.assert_contains('R2for1', response.body)
def test_reviewer_cannot_impersonate_another_reviewer(self):
"""Test that one reviewer cannot use another's review step key."""
email1 = '*****@*****.**'
name1 = 'Student 1'
submission1 = transforms.dumps([
{'index': 0, 'type': 'regex', 'value': 'S1-1', 'correct': True},
{'index': 1, 'type': 'choices', 'value': 3, 'correct': False},
{'index': 2, 'type': 'regex', 'value': 'is-S1', 'correct': True},
])
payload1 = {
'answers': submission1, 'assessment_type': LEGACY_REVIEW_UNIT_ID}
email2 = '*****@*****.**'
name2 = 'Student 2'
submission2 = transforms.dumps([
{'index': 0, 'type': 'regex', 'value': 'S2-1', 'correct': True},
{'index': 1, 'type': 'choices', 'value': 3, 'correct': False},
{'index': 2, 'type': 'regex', 'value': 'not-S1', 'correct': True},
])
payload2 = {
'answers': submission2, 'assessment_type': LEGACY_REVIEW_UNIT_ID}
email3 = '*****@*****.**'
name3 = 'Student 3'
submission3 = transforms.dumps([
{'index': 0, 'type': 'regex', 'value': 'S3-1', 'correct': True},
{'index': 1, 'type': 'choices', 'value': 3, 'correct': False},
{'index': 2, 'type': 'regex', 'value': 'not-S1', 'correct': True},
])
payload3 = {
'answers': submission3, 'assessment_type': LEGACY_REVIEW_UNIT_ID}
# Student 1 submits the assignment.
actions.login(email1)
actions.register(self, name1)
response = actions.submit_assessment(
self, LEGACY_REVIEW_UNIT_ID, payload1)
actions.logout()
# Student 2 logs in and submits the assignment.
actions.login(email2)
actions.register(self, name2)
response = actions.submit_assessment(
self, LEGACY_REVIEW_UNIT_ID, payload2)
# Student 2 requests a review, and is given Student 1's assignment.
response = actions.request_new_review(self, LEGACY_REVIEW_UNIT_ID)
review_step_key_2_for_1 = get_review_step_key(response)
actions.assert_contains('S1-1', response.body)
actions.logout()
# Student 3 logs in, and submits the assignment.
actions.login(email3)
actions.register(self, name3)
response = actions.submit_assessment(
self, LEGACY_REVIEW_UNIT_ID, payload3)
# Student 3 tries to view Student 1's assignment using Student 2's
# review step key, but is not allowed to.
response = actions.view_review(
self, LEGACY_REVIEW_UNIT_ID, review_step_key_2_for_1,
expected_status_code=404)
# Student 3 logs out.
actions.logout()