def test_passed_based_on_signing_summary(self):
"""Test that the 'passed_auto_validation' flag is correctly added,
based on signing summary."""
result = annotate_validation_results(self.get_validation())
assert result['passed_auto_validation'] is True
validation = self.get_validation()
validation['signing_summary'] = {
'high': 0,
'medium': 0,
'low': 1,
'trivial': 0
}
result = annotate_validation_results(validation)
assert result['passed_auto_validation'] is False
result = annotate_validation_results(
(self.get_validation(), self.get_validation()))
assert result['passed_auto_validation'] is True
assert (result['signing_summary'] == {
'high': 0,
'medium': 0,
'low': 0,
'trivial': 0
})
assert (result['signing_ignored_summary'] == {
'high': 0,
'medium': 0,
'low': 1,
'trivial': 0
})
def test_single_validation(self):
"""Test that passing a single validation result works."""
result = annotate_validation_results(self.get_validation())
assert (result['messages'][0]['id'] ==
self.VALIDATION['messages'][0]['id'])
def from_upload(cls, upload, version, platform, is_beta=False,
parse_data={}):
addon = version.addon
file_ = cls(version=version, platform=platform)
upload.path = amo.utils.smart_path(nfd_str(upload.path))
ext = os.path.splitext(upload.path)[1]
if ext == '.jar':
ext = '.xpi'
file_.filename = file_.generate_filename(extension=ext or '.xpi')
# Size in bytes.
file_.size = storage.size(upload.path)
data = cls.get_jetpack_metadata(upload.path)
if 'sdkVersion' in data and data['sdkVersion']:
file_.jetpack_version = data['sdkVersion'][:10]
if file_.jetpack_version:
Tag(tag_text='jetpack').save_tag(addon)
file_.builder_version = data['builderVersion']
file_.no_restart = parse_data.get('no_restart', False)
file_.strict_compatibility = parse_data.get('strict_compatibility',
False)
file_.is_multi_package = parse_data.get('is_multi_package', False)
if is_beta and addon.status == amo.STATUS_PUBLIC:
file_.status = amo.STATUS_BETA
elif addon.trusted:
# New files in trusted add-ons automatically receive the correct
# approved status for their review class.
if addon.status == amo.STATUS_PUBLIC:
file_.status = amo.STATUS_PUBLIC
elif addon.status in amo.LITE_STATUSES:
file_.status = amo.STATUS_LITE
file_.hash = file_.generate_hash(upload.path)
if upload.validation:
validation = json.loads(upload.validation)
if validation['metadata'].get('requires_chrome'):
file_.requires_chrome = True
file_.save()
log.debug('New file: %r from %r' % (file_, upload))
# Move the uploaded file from the temp location.
destinations = [version.path_prefix]
if file_.status in amo.MIRROR_STATUSES:
destinations.append(version.mirror_path_prefix)
for dest in destinations:
copy_stored_file(upload.path,
os.path.join(dest, nfd_str(file_.filename)))
if upload.validation:
# Import loop.
from devhub.tasks import annotate_validation_results
validation = annotate_validation_results(validation)
FileValidation.from_json(file_, validation)
return file_
def test_signing_summary_added(self):
"""Test that if a signing summary is missing, an empty one is
added."""
assert 'signing_summary' not in self.VALIDATION
result = annotate_validation_results(self.get_validation())
assert (result['signing_summary'] ==
{'high': 0, 'medium': 0, 'low': 0, 'trivial': 0})
def test_multiple_validations(self):
"""Test that multiple validations, to be merged by
ValidationComparator, work."""
result = annotate_validation_results((self.get_validation(),
self.get_validation()))
assert (result['messages'][0]['matched'] ==
self.VALIDATION['messages'][0])
def test_passed_based_on_signing_summary(self):
"""Test that the 'passed_auto_validation' flag is correctly added,
based on signing summary."""
result = annotate_validation_results(self.get_validation())
assert result['passed_auto_validation'] is True
validation = self.get_validation()
validation['signing_summary'] = {'high': 0, 'medium': 0, 'low': 1,
'trivial': 0}
result = annotate_validation_results(validation)
assert result['passed_auto_validation'] is False
result = annotate_validation_results((self.get_validation(),
self.get_validation()))
assert result['passed_auto_validation'] is True
assert (result['signing_summary'] ==
{'high': 0, 'medium': 0, 'low': 0, 'trivial': 0})
assert (result['signing_ignored_summary'] ==
{'high': 0, 'medium': 0, 'low': 1, 'trivial': 0})
def from_upload(cls,
upload,
version,
platform,
is_beta=False,
parse_data={}):
addon = version.addon
file_ = cls(version=version, platform=platform)
upload.path = amo.utils.smart_path(nfd_str(upload.path))
ext = os.path.splitext(upload.path)[1]
if ext == '.jar':
ext = '.xpi'
file_.filename = file_.generate_filename(extension=ext or '.xpi')
# Size in bytes.
file_.size = storage.size(upload.path)
data = cls.get_jetpack_metadata(upload.path)
if 'sdkVersion' in data and data['sdkVersion']:
file_.jetpack_version = data['sdkVersion'][:10]
if file_.jetpack_version:
Tag(tag_text='jetpack').save_tag(addon)
file_.no_restart = parse_data.get('no_restart', False)
file_.strict_compatibility = parse_data.get('strict_compatibility',
False)
file_.is_multi_package = parse_data.get('is_multi_package', False)
if is_beta and addon.status == amo.STATUS_PUBLIC:
file_.status = amo.STATUS_BETA
elif addon.trusted:
# New files in trusted add-ons automatically receive the correct
# approved status for their review class.
if addon.status == amo.STATUS_PUBLIC:
file_.status = amo.STATUS_PUBLIC
elif addon.status in amo.LITE_STATUSES:
file_.status = amo.STATUS_LITE
file_.hash = file_.generate_hash(upload.path)
file_.original_hash = file_.hash
if upload.validation:
validation = json.loads(upload.validation)
if validation['metadata'].get('requires_chrome'):
file_.requires_chrome = True
file_.save()
log.debug('New file: %r from %r' % (file_, upload))
# Move the uploaded file from the temp location.
destinations = [version.path_prefix]
if file_.status in amo.MIRROR_STATUSES:
destinations.append(version.mirror_path_prefix)
for dest in destinations:
copy_stored_file(upload.path,
os.path.join(dest, nfd_str(file_.filename)))
if upload.validation:
# Import loop.
from devhub.tasks import annotate_validation_results
from devhub.utils import ValidationAnnotator
validation = annotate_validation_results(validation)
FileValidation.from_json(file_, validation)
# Copy annotations from any previously approved file.
ValidationAnnotator(file_).update_annotations()
return file_
